Changeset 531 for elixir/trunk/elixir/relationships.py

Timestamp:

09/02/10 12:07:44 (21 months ago)

Author:

ged

Message:

add some comments, FIXME, etc...

Files:

• elixir/trunk/elixir/relationships.py (modified) (3 diffs)

elixir/trunk/elixir/relationships.py

@@ -629 +629 @@
         if isinstance(self.target, EntityMeta):
             # make sure the target has all its pk set up
+            #FIXME: this is not enough when specifying target_column manually,
+            # on unique, non-pk col, see tests/test_m2o.py:test_non_pk_forward
             self.target._descriptor.create_pk_cols()
+
         #XXX: another option, instead of the FakeTable, would be to create an
         # EntityDescriptor for the SA class.
@@ -650 +653 @@
                             "'%s' using the following columns: %s."
                             % (self.entity.table.name, colnames))
+            else:
+                # in this case we let SA handle everything. 
+                # XXX: we might want to try to build join clauses anyway so 
+                # that we know whether there is an ambiguity or not, and
+                # suggest using colname if there is one
+                pass
             if self.field:
                 raise NotImplementedError(
@@ -803 +812 @@
         # (ManyToOne).
         if self.entity.table is self.target.table:
-            #FIXME: IF this code is of any use, it will probably break for
-            # autoloaded tables
+            # When using a manual/autoloaded table, it will be assigned
+            # an empty list, which doesn't seem to upset SQLAlchemy
             kwargs['remote_side'] = self.inverse.foreign_key