Changeset 367

Timestamp:

07/15/08 17:29:04 (5 years ago)

Author:

cleverdevil

Message:

The constructor for Entity no longer called from_dict as it can lead to unexpected results that may confuse users, and broke some projects that depended on the old functionality. In addition, the set method also no longer calls from_dict either, for the same reasons.

Now, to_dict and from_dict are fairly isolated and are only used when explicitly requested.

Note: Entity.__init__ does not just pass through to Entity.set because the additional copy of the keyword arguments triggered by the **kwargs in the call caused problems in my testing.

Files:

• elixir/trunk/elixir/entity.py (modified) (1 diff)

elixir/trunk/elixir/entity.py

@@ -873 +873 @@
 
     def __init__(self, **kwargs):
-        self.from_dict(kwargs)
-
+        for key, value in kwargs.iteritems(): setattr(self, key, value)
+        
     def set(self, **kwargs):
-        self.from_dict(kwargs)
+        for key, value in kwargs.iteritems(): setattr(self, key, value)
 
     def update_or_create(cls, data, surrogate=True):