Changeset 362

Timestamp:

07/11/08 17:18:56 (4 years ago)

Author:

ged

Message:

• Added support for callables for some arguments on relationships:
  primaryjoin, secondaryjoin and remote_side. It means those can be evaluated
  at setup time (when tables and their columns already exist) instead of
  definition time (closes #50).
  
• Misc cleanup
  

Location:

elixir/trunk

Files:

• CHANGES (modified) (3 diffs)
• elixir/properties.py (modified) (2 diffs)
• elixir/relationships.py (modified) (3 diffs)
• tests/test_o2m.py (modified) (1 diff)

elixir/trunk/CHANGES

@@ -17 +17 @@
         pass
     A.name = Field(String(32))
-- Added add_mapper_property and add_table_column helper methods in
-  EntityBuilders.
+- Added add_table_column, add_mapper_property and add_mapper_extension helper
+  methods in EntityBuilders.
 - Added full_tablename property on EntityDescriptor (includes schema name if
   any).
@@ -25 +25 @@
 - Added support for filtered OneToMany relationships. Produce viewonly
   relations. See source:elixir/trunk/tests/test_o2m.py for an example.
+- Added support for callables for some arguments on relationships: primaryjoin,
+  secondaryjoin and remote_side. It means those can be evaluated at setup time
+  (when tables and their columns already exist) instead of definition time.
 
 Changes:
@@ -35 +38 @@
       SA 0.4)
     * autoexpire=True (with SA 0.5).
-- removed objectstore and other SA 0.3 or older support code.
+- removed objectstore and other SA 0.3 (or older) support code.
 
 Bug fixes:

elixir/trunk/elixir/properties.py

@@ -58 +58 @@
 
     def create_tables(self):
-        pass
+        '''
+        Subclasses may override this method to create tables.
+        '''
 
     def after_table(self):
@@ -64 +66 @@
 
     def create_properties(self):
-        pass
+        '''
+        Subclasses may override this method to add properties to the involved 
+        entity.
+        '''
 
     def before_mapper(self):

elixir/trunk/elixir/relationships.py

@@ -380 +380 @@
         '''
 
-    def create_tables(self):
-        '''
-        Subclasses (ie. concrete relationships) may override this method to
-        create secondary tables.
-        '''
-
     def create_properties(self):
-        '''
-        Subclasses (ie. concrete relationships) may override this method to
-        add properties to the involved entities.
-        '''
         if self.property or self.backref:
             return
 
         kwargs = self.get_prop_kwargs()
+        if 'order_by' in kwargs:
+            kwargs['order_by'] = \
+                self.target._descriptor.translate_order_by(kwargs['order_by'])
+
+        # transform callable arguments
+        for arg in ('primaryjoin', 'secondaryjoin', 'remote_side'):
+            kwarg = kwargs.get(arg, None)
+            if callable(kwarg):
+                kwargs[arg] = kwarg()
 
         # viewonly relationships need to create "standalone" relations (ie
@@ -664 +663 @@
     uselist = True
 
-    def get_prop_kwargs(self):
-        kwargs = super(OneToMany, self).get_prop_kwargs()
-
-        if 'order_by' in kwargs:
-            kwargs['order_by'] = \
-                self.target._descriptor.translate_order_by(
-                    kwargs['order_by'])
-
-        return kwargs
-
 
 class ManyToMany(Relationship):
@@ -857 +846 @@
 
         kwargs.update(self.kwargs)
-
-        if 'order_by' in kwargs:
-            kwargs['order_by'] = \
-                self.target._descriptor.translate_order_by(kwargs['order_by'])
 
         return kwargs

elixir/trunk/tests/test_o2m.py

@@ -108 +108 @@
 
     def test_viewonly(self):
-        # the callable primaryjoin seem to be unstable... sometime it works,
-        # sometime it doesn't... for no apparent reason. I think it's a bug in
-        # the current revision of SQLAlchemy I'm using (4900).
         class User(Entity):
             two_blurbs = OneToMany('Blurb', primaryjoin=lambda: